Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mars crashes on ray >= 1.2.0 #1998

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Fix mars crashes on ray >= 1.2.0 #1998

merged 3 commits into from
Feb 24, 2021

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

Fix mars crashes on ray >= 1.2.0

Related issue number

Closes #1997

@hekaisheng hekaisheng added mod: ray integration to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working labels Feb 24, 2021
@hekaisheng hekaisheng added this to In progress in Misc via automation Feb 24, 2021
@hekaisheng hekaisheng added this to PR-In progress in v0.7 Release via automation Feb 24, 2021
@hekaisheng hekaisheng added this to the v0.7.0a6 milestone Feb 24, 2021
@qinxuye qinxuye mentioned this pull request Feb 24, 2021
Open
raulchen
raulchen previously approved these changes Feb 24, 2021
View reviewed changes
Copy link

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Feb 24, 2021
@hekaisheng hekaisheng dismissed stale reviews from raulchen and themself via 2b768b8 February 24, 2021 07:14
Misc automation moved this from Reviewer approved to Review in progress Feb 24, 2021
v0.7 Release automation moved this from PR-In progress to PR-Needs review Feb 24, 2021
v0.7 Release automation moved this from PR-In progress to PR-Needs review Feb 24, 2021
@fyrestone fyrestone requested a review from wjsi as a code owner February 24, 2021 08:27
qinxuye
qinxuye approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from Review in progress to Reviewer approved Feb 24, 2021
@qinxuye qinxuye merged commit 1d8c77c into mars-project:master Feb 24, 2021
Misc automation moved this from Reviewer approved to Done Feb 24, 2021
v0.7 Release automation moved this from PR-Needs review to PR-Done Feb 24, 2021
hekaisheng pushed a commit to hekaisheng/mars that referenced this pull request Feb 25, 2021
@fyrestone
Fix mars crashes on ray >= 1.2.0 (mars-project#1998)
d954359 
(cherry picked from commit 1d8c77c)
@hekaisheng hekaisheng mentioned this pull request Feb 25, 2021
Merged
wjsi pushed a commit that referenced this pull request Feb 25, 2021
@hekaisheng
[BACKPORT] Fix mars crashes on ray >= 1.2.0 (#1998) (#2003)
80ff14c
@qinxuye qinxuye removed the to be backported Indicate that the PR need to be backported to stable branch label Feb 25, 2021
@qinxuye qinxuye added the backported already PR has been backported label Feb 25, 2021
@fyrestone fyrestone added this to Done in Mars on Ray Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@raulchen raulchen raulchen left review comments

@hekaisheng hekaisheng hekaisheng left review comments

@wjsi wjsi Awaiting requested review from wjsi

Assignees
No one assigned
Labels
backported already PR has been backported mod: ray integration type: bug Something isn't working
Projects
Mars on Ray
Done
Misc
  
Done
v0.7 Release
PR-Done
Milestone
v0.7.0a6
4 participants
@fyrestone @qinxuye @raulchen @hekaisheng