Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move opcodes out of protobuf definition #1944

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Move opcodes out of protobuf definition #1944

merged 3 commits into from
Jan 28, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Jan 28, 2021

What do these changes do?

Move opcodes into mars/opcode.py

Related issue number

@wjsi wjsi added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: serialization labels Jan 28, 2021
@wjsi wjsi added this to the v0.7.0a5 milestone Jan 28, 2021
@wjsi wjsi requested a review from hekaisheng as a code owner January 28, 2021 05:42
@wjsi wjsi added this to PR-In progress in v0.7 Release via automation Jan 28, 2021
@wjsi wjsi requested a review from qinxuye as a code owner January 28, 2021 05:42
@wjsi wjsi added this to In progress in Misc via automation Jan 28, 2021
qinxuye
qinxuye approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Jan 28, 2021
@qinxuye qinxuye merged commit 2cb0c83 into mars-project:master Jan 28, 2021
Misc automation moved this from Reviewer approved to Done Jan 28, 2021
v0.7 Release automation moved this from PR-In progress to PR-Done Jan 28, 2021
@wjsi wjsi deleted the enh/split_opcodes branch January 28, 2021 10:53
wjsi added a commit to wjsi/mars that referenced this pull request Jan 28, 2021
@wjsi
Move opcodes out of protobuf definition (mars-project#1944)
cae0b8f
@wjsi wjsi mentioned this pull request Jan 28, 2021
Merged
qinxuye pushed a commit that referenced this pull request Jan 28, 2021
@wjsi
[BACKPORT] Move opcodes out of protobuf definition (#1944) (#1947)
2eca131
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees
No one assigned
Labels
backported already PR has been backported mod: serialization type: enhancement request
Projects
Misc
  
Done
v0.7 Release
PR-Done
Milestone
v0.7.0a5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjsi @qinxuye