Eccodestransfer #57
Open
Eccodestransfer #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marqh
force-pushed
the
eccodestransfer
branch
3 times, most recently
from
83d8968 to
d32040a
Compare
DPeterK
reviewed
Apr 10, 2017
| result = ma.masked_equal(item, _MDI) | ||
| mdis = [mdi for mdi in _MDIs] | ||
| result = ma.masked_equal(item, mdis[0]) | ||
| result = ma.masked_equal(result, mdis[1]) |
There was a problem hiding this comment.
Can we be sure there will only be two MDI values?
| skip_irisgrib_fails = skipIf(iris_internal_grib_module is None, | ||
| 'Test(s) are not currently ussable with ' | ||
| '"iris_grib".') | ||
| skip_irisgrib_fails = skipIf(True, 'Test(s) are not currently ussable with ' |
There was a problem hiding this comment.
Looks like you've inherited a typo: 'ussable' --> 'usable'.
| import gribapi | ||
|
|
||
| from iris.fileformats.grib._load_convert import _MDIs | ||
| _mdis = [mdi for mdi in _MDIs] |
There was a problem hiding this comment.
Could you not just use MDIs directly? This seems like an unnecessary variable definition.
| from iris.fileformats.grib._load_convert import data_cutoff | ||
| from iris.tests import mock | ||
|
|
||
| MDI = [mdi for mdi in _MDIs][1] |
| grid_definition_template_4_and_5, _MDIs | ||
| from iris.tests import mock | ||
|
|
||
| MDI = [mdi for mdi in _MDIs][1] |
| product_definition_template_40, _MDIs | ||
| from iris.tests.unit.fileformats.grib.load_convert import empty_metadata | ||
|
|
||
| MDI = [mdi for mdi in _MDIs][1] |
| from iris.fileformats.grib._load_convert import Probability, _MDIs | ||
| from iris.tests import mock | ||
|
|
||
| MDI = [mdi for mdi in _MDIs][1] |
|
|
||
| # Reference GRIB2 Regulation 92.1.12. | ||
|
|
||
| MDI = [mdi for mdi in _MDIs][1] |
| _MDIs | ||
| from iris.tests import mock | ||
|
|
||
| MISSING_LEVEL = [mdi for mdi in _MDIs][1] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.