Don't use lazy wrappers for cube shape and dtype. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marqh
pushed a commit
that referenced
this pull request
Feb 18, 2017
marqh
pushed a commit
that referenced
this pull request
Feb 23, 2017
marqh
pushed a commit
that referenced
this pull request
Feb 24, 2017
marqh
pushed a commit
that referenced
this pull request
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the severe test slownesses we have been seeing.
I think there was no good reason to implement cube.dtype and cube.shape via cube.lazy_data().
The cube._my_data will always have viable dtype and shape properties, whether real or lazy.