Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing markdown-it instance as markdown constructor option #164

Merged
merged 7 commits into from
May 30, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented May 26, 2019

We are organizing confused features. This PR will allow passing markdown-it instance as markdown constructor option, to wrap any instance by Marpit.

const markdownIt = new MarkdownIt()
const marp = new Marp({ markdown: markdownIt })

As before, you can also pass markdown-it constructor options, because it considers need for YAML configuration by Marp CLI.

markdownItPlugins interface had difficult usage is now deprecated. It as same meaning as using added constructor option.

@yhatt yhatt merged commit b59001b into master May 30, 2019
@yhatt yhatt deleted the wrap-markdown-it-instance branch May 30, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant