Simplify Marpit plugins by using injected instance into markdown-it instance #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, Marpit plugins require injected
marpit
member into markdown-it instance. We've updated plugins to use injected instance for reading Marpit options.We think that rarely happen this case, but you won't have to care params when use Marpit plugins individually. Just inject Marpit instance to
marpit
member.If you were using
marpit.markdownItPlugins
interface,marpit.markdown
andmarkdownit.marpit
would be updated to the last injected markdown-it/Marpit instance.The purpose of this change is to prepare building an escape hatch of deprecated options. By injecting opinionated feature by individual plugins instead of controlling plugin's feature by Marpit options, the power user may build custom Marpit from a plain markdown-it instance with just picking favorite plugins. However, there is not a desire like that at this moment, so we won't work splitting plugins actively now.