Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation about @import rule for theme #75

Closed
yhatt opened this issue Sep 19, 2018 · 0 comments
Closed

Wrong documentation about @import rule for theme #75

yhatt opened this issue Sep 19, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@yhatt
Copy link
Member

yhatt commented Sep 19, 2018

Documentation says:

@import must precede all other statements excepted @charset. It follows the original specification.

However, this restriction is gone by #72. @import could work correctly in anywhere of the CSS root, because we have a roll-up process for @import and @charset before convertion. It becomes that @import and @import-theme behave almost same behavior while theme conversion.

We have to update documentation to avoid confusion.

@yhatt yhatt added the good first issue Good for newcomers label Sep 19, 2018
yhatt added a commit that referenced this issue Sep 20, 2018
Since v0.1.1, import at-rule could work correctly in anywhere of
the CSS root. Related to #75.
@yhatt yhatt closed this as completed in #77 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant