Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored strong element in headings for highlighting #59

Merged
merged 3 commits into from
Jan 13, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jan 12, 2019

Update theme CSS to support highlighting text in header through **strong**.

# Support **highlighting**
Default Gaia Uncover
default screenshot_2019-01-12 screenshot screenshot_2019-01-12 screenshot 2 screenshot_2019-01-12 screenshot 5
invert screenshot_2019-01-12 screenshot 1 screenshot_2019-01-12 screenshot 3 screenshot_2019-01-12 screenshot 6
gaia screenshot_2019-01-12 screenshot 4

Typically the headings has a bold text by browser default style, so <strong> element by **this markup** would not affect to the rendering of headings. Therefore, the custom style for <strong> in headings would be allowed.

The pre-released Marp already has a ==markup== for highlighting, but we have not adopted because it is against CommonMark. The added style can use as the alternative of it.

@yhatt yhatt merged commit 700049c into master Jan 13, 2019
@yhatt yhatt deleted the highlight-in-header branch January 13, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant