Update browser script to observe root resolved from script

marp-team · Aug 18, 2020 · 3e30fc6 · 3e30fc6
1 parent 8f825d3
commit 3e30fc6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/scripts/browser.js b/scripts/browser.js
@@ -1,3 +1,3 @@
-import browser from '../src/browser'
+import { browser } from '../src/browser'
 
-browser()
+browser(document.currentScript.getRootNode())
diff --git a/src/browser.ts b/src/browser.ts
@@ -10,10 +10,7 @@ export const browser = (target: ParentNode = document): (() => void) => {
     )
   }
 
-  if (target[marpCoreBrowserScript]) {
-    console.warn("Marp Core's browser script has already executed.")
-    return target[marpCoreBrowserScript]
-  }
+  if (target[marpCoreBrowserScript]) return target[marpCoreBrowserScript]
 
   const cleanupObserver = observer({ target })
   const cleanup = () => {

diff --git a/src/script/browser-script.ts b/src/script/browser-script.ts
@@ -1,3 +1,4 @@
-const dummy = 'This is a placeholder for the content of built browser script.'
+const placeholder =
+  'This is a placeholder for the content of built browser script.'
 
-export default dummy
+export default placeholder