Upgrade Node and dependent packages to the latest #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 527a504.
|
A new stable Chrome (73) is blocking tests used Puppeteer. According to I/O dump, Chrome seems to be crashed with following message: Related: puppeteer/puppeteer#3774 |
- Puppeteer has already default option `--disable-dev-shm-usage`. - BGPT no longer works from Puppeteer >= v1.13.0 See: puppeteer/puppeteer@ef2251d
Use Chromium supported by Puppeteer instead.
yhatt
commented
Mar 19, 2019
| command: | | ||
| mkdir -p ~/.puppeteer && cd ~/.puppeteer | ||
| npm i puppeteer | ||
| echo "export CHROME_PATH=$(node -e "console.log(require('puppeteer').executablePath())")" >> $BASH_ENV |
There was a problem hiding this comment.
Add workaround for broken Chrome 73. We have to use Chromium supported by Puppeteer (Chromium 74) within image.
We have confirmed to work conversion in Chrome 73 with out of container (Windows/macOS/Linux).
| @@ -257,24 +257,14 @@ export class Converter { | |||
|
|
|||
| private static async runBrowser() { | |||
| if (!Converter.browser) { | |||
| // Fix the rendered position of elements in <foreignObject> | |||
| // See: https://bugs.chromium.org/p/chromium/issues/detail?id=467484 | |||
| const args = ['--enable-blink-gen-property-trees'] | |||
There was a problem hiding this comment.
Puppeteer v1.13.0 no longer works BGPT feature.
puppeteer/puppeteer@ef2251d
It seems to have no critical problems while rendering PDF and images.
| : chromeFinder[process.platform] | ||
|
|
||
| if (process.env.IS_DOCKER || process.env.CI) | ||
| args.push('--disable-dev-shm-usage') |
There was a problem hiding this comment.
Puppeteer already has --disable-dev-shm-usage option by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Node (v10.15.3) and dependent packages to the latest version by using
yarn upgrade --latest.This PR is included update of Marpit v0.8.0 and Marp Core v0.7.0.
Notable changes
@types/chokidarhas removed. chokidar has already provided type definitions..circleci/config.ymlas like as the other marp-team projects.Dockerfileto use matched Puppeteer version.