-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the first slide convertible into image #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had forgotten restoration from debug.
JPEG quality is allowed when `-o` has filename with jpeg extension.
yhatt
changed the title
[WIP] Convert the first slide into image
[WIP] Make the first slide convertible into image
Feb 1, 2019
yhatt
changed the title
[WIP] Make the first slide convertible into image
Make the first slide convertible into image
Feb 1, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the first slide convertible into PNG and JPEG image by Puppeteer.
It would be useful for creating Open Graph image that can specify with
image
global directive and--og-image
option. This purpose is very similar to mdx-deck'sscreenshot
command.You might think to want to convert from the whole of slide deck into multiple images, like decktape's
--screenshots
option. We have to refactor the conversion logic to support outputting multiple files in order to realize that. So it is not yet supported in this PR.ToDo