New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convertFileToPDF: Use base64 string as URL #61

Merged

yhatt merged 1 commit into marp-team:master from kamijin-fanta:master

Jan 25, 2019

+1 −1

Contributor

kamijin-fanta commented Jan 25, 2019

about

there is a problem that PDF is not generated in Chrome Canary.
it's generate a blank page.

changes

change output URL from plain-text to base64

environment

Chrome Version: 73.0.3683.0 (Official Build) canary (64 bit)


          convertFileToPDF: Use base64 string as URL

4e6f534

Member

yhatt commented Jan 25, 2019

Awesome, thanks!

yhatt merged commit 2a94c78 into marp-team:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet