Reflect lang global directive to HTML templates
#558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
changed the title
lang directive in HTML templateslang global directive to HTML templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langdirective has added since Marpit framework v2.6.0. (marp-team/marpit#376)By this change,
langattribute in<html>element of templates will determine with the priority in order of below:langglobal directive was defined in Markdown, it would be set aslangattribute of<html>.langprefers the engine constructor option passed byoptionsin configuration file.options.langis not defined,langfield of configuration file will be used. (Already implemented)langfield, Marp CLI will fallback to OS locale. This is the most general case for now. (Already implemented)Closes #542.