Render HTML via Page.setContent() instead of data URI
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a huge Markdown document, the slide document HTML may reach to the limit of data URI length.
yhatt
added a commit
that referenced
this pull request
Sep 24, 2023
As same as #551, the preview window may fail to open data URI due to the limitation of the display length.. If passed data URI to the preview window, Marp CLI try to convert to Blob URL and open it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a huge Markdown document, the encoded slide HTML may reach to the limit of data URI length.
I updated how to render a HTML for conversion to use Puppeteer's
Page.setContent(). Resolves #545.