Replace is-docker to is-inside-container
#544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppeteer is known that it's hard to run on the virtualized container. Marp CLI has Docker container detection to mitigate that, and apply
--no-sandboxinto Chromium process if detected.This PR makes changing to replace
is-dockermodule intois-inside-container, to detect more kind of virtualized containers (e.g. Podman).is-inside-containerstill includes Docker container detection from the same version as the currentis-dockermodule, so there should be no degradation in detection.Related: #543
Note
I don't know that this replacement will work also on AWS ECS. #543 may be closable if ECS was using Podman.