Support ES Modules and async resolution for engine script #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--engine
option now supports using ES Modules and async function engine.ESM
Async function
with ES Modules
with CommonJS
Backward compatibillity
In the most cases, a formerly used
engine.js
with CommonJS should keep working.However, if a Node project that Marp CLI was installed has been marked as
type: module
inpackage.json
, users may have to change the engine file extension from.js
to.cjs
for making clear of the intent of using CommonJS.Notes
v8-compile-cache
due to incompatibillity with ES Modules. Related: v2.2.1 leads to segmentation fault (core dumped) #487