Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the id for scoping bespoke template styles #516

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 16, 2023

For making smaller the output HTML, we had used ID p to scope styles for bespoke template interfaces. When Marp Core v3.6.0 is coming to Marp CLI, it may conflict with user-generated anchor by Markdown headings just like # p.

Thus, we've changed the anchor for the whole of HTML document from p to :$p. Both of : and $ are not using as a character of the slug anchor by the default slugifier in Marp Core v3.6.0 so the interface of bespoke template will become safe from user-generated anchors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant