Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Puppeteer's new headless mode by PUPPETEER_HEADLESS_MODE=new env #508

Merged
merged 9 commits into from
Mar 3, 2023

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Feb 27, 2023

The latest Puppeteer allows headless: 'new' option to use more compatible browser rendering that is same as the headful mode.
https://developer.chrome.com/articles/new-headless/

For the time being at least, Marp CLI can unlock the new headless mode an environment value PUPPETEER_HEADLESS_MODE=new.

PUPPETEER_HEADLESS_MODE=new marp ./new-headless.md --pdf

If it became stable, we will change the default headless mode to new. If so, users would need to opt-in for using legacy headless mode via PUPPETEER_HEADLESS_MODE=old.

@yhatt yhatt marked this pull request as ready for review March 2, 2023 14:57
Due to failure of new headless mode in macOS, users can try it with an
optional env PUPPETEER_HEADLESS_MODE=new for the time being.
@yhatt yhatt changed the title Adopt Puppeteer's new headless mode Adopt Puppeteer's new headless mode by PUPPETEER_HEADLESS_MODE=new env Mar 3, 2023
@yhatt yhatt changed the title Adopt Puppeteer's new headless mode by PUPPETEER_HEADLESS_MODE=new env Support Puppeteer's new headless mode by PUPPETEER_HEADLESS_MODE=new env Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant