Rewrote a preview feature for supporting the regular conversion and multiple files #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Dec 18, 2018
test/preview.ts
Outdated
| await instance.carlo | ||
| .browserForTest() | ||
| .process() | ||
| .kill() |
There was a problem hiding this comment.
First I tried await instance.carlo.browserForTest().close(), but sometimes it throws read ECONNRESET in remaining tests.
yhatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will apply the rewritten preview feature for supporting the regular conversion and multiple files.
I rewrote
Previewclass based onEventEmitter, and wrapped Carlo. It supports multiple windows, so Marp CLI can use--previewoption with the regular conversion.By lacked Node 6 support in Carlo, it is hard to keep maintaining to support Node 6. Thus, we have dropped Node 6 support in this PR. The EOL of Boron LTS will reach in next April. You have to upgrade Node to >= 8 LTS if you still use Boron.
ToDo