Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHROME_PATH resolver for .app directory in Mac #463

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Add CHROME_PATH resolver for .app directory in Mac #463

merged 7 commits into from
Jul 20, 2022

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jul 17, 2022 •
edited
Loading

When setting the directory path ending with .app as CHROME_PATH env in macOS, Marp CLI tries to parse Contents/Info.plist inside the specific directory and detect the real executable binary of the app from CFBundleExecutable.

If found, we run Chrome executable resolver provided by chrome-launcher with an updated CHROME_PATH env.

Close #460.

ToDo

  • Add test

@yhatt yhatt merged commit e072ef7 into main Jul 20, 2022
@yhatt yhatt deleted the resolving-app-chrome-path-in-mac branch July 20, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS: Auto detection of executable path when CHROME_PATH has pointed .app folder
1 participant
@yhatt