Ignore node_modules in globbing

.gitignore

@@ -1,5 +1,7 @@
 lib/
 tmp/
+node_modules/**
+!/test/_files/node_modules/ignore.*
 
 ########## gitignore.io ##########
 # Created by https://www.gitignore.io/api/node,windows,macos,linux,sublimetext,emacs,vim,visualstudiocode
@@ -128,7 +130,6 @@ bower_components
 build/Release
 
 # Dependency directories
-node_modules/
 jspm_packages/
 
 # Typescript v1 declaration files

CHANGELOG.md

@@ -8,6 +8,10 @@
 - Output the configured engine in `version` (`-v`) option ([#43](https://github.com/marp-team/marp-cli/pull/43))
 - Experimental support `--preview` option to open preview window provided by [Carlo](https://github.com/GoogleChromeLabs/carlo) ([#44](https://github.com/marp-team/marp-cli/pull/44))
 
+### Fixed
+
+- Ignore `node_modules` in globbing ([#45](https://github.com/marp-team/marp-cli/pull/45))
+
 ## v0.0.14 - 2018-11-24
 
 ### Security

src/file.ts

@@ -109,6 +109,7 @@ export class File {
     return (await globby(pathes, {
       absolute: true,
       expandDirectories: { files: markdownExtensions.map(ext => `*.${ext}`) },
+      ignore: ['**/node_modules'],
     })).map(p => new File(p))
   }
 

src/server.ts

@@ -102,10 +102,11 @@ export class Server {
         const { name, stat } = f
         const directory = stat && stat.isDirectory()
         const parent = name === '..' && directory
+        const nodeModules = name === 'node_modules' && directory
         const convertible =
           !parent && (await this.validateMarkdown(name, stat)).valid
 
-        files.push({ convertible, directory, name, parent, stat })
+        files.push({ convertible, directory, name, nodeModules, parent, stat })
       }
 
       callback(null, serverIndex({ directory, files, path, style }))

src/server/index.pug

@@ -9,7 +9,7 @@ html
     h1= directory
     ul.index
       each file in files
-        li(class={ convertible: file.convertible, directory: file.directory })
+        li(class={ convertible: file.convertible, directory: file.directory, nodeModules: file.nodeModules })
           a.link.file(href=encodeURIComponent(file.name))= file.name
 
           if file.convertible

src/server/index.scss

@@ -37,7 +37,8 @@ ul.index {
       background-image: url('./assets/icon-directory.svg');
     }
 
-    &:not(.convertible):not(.directory) {
+    &:not(.convertible):not(.directory),
+    &.nodeModules {
       display: none;
     }
 

src/theme.ts

@@ -150,6 +150,7 @@ export class ThemeSet {
     return await globby(fn, {
       absolute: true,
       expandDirectories: { files: themeExtensions },
+      ignore: ['**/node_modules'],
     })
   }
 }

test/server.ts

@@ -138,8 +138,9 @@ describe('Server', () => {
 
         const $ = cheerio.load(response.text)
         expect($('h1').text()).toBe('/')
-        expect($('ul.index li')).toHaveLength(6) // Actual file count
-        expect($('ul.index li.directory')).toHaveLength(2) // Directories
+        expect($('ul.index li')).toHaveLength(7) // Actual file count
+        expect($('ul.index li.directory')).toHaveLength(3) // Directories
+        expect($('ul.index li.directory.nodeModules')).toHaveLength(1)
         expect($('ul.index li.convertible')).toHaveLength(3) // Markdown files
 
         // PDF query parameter