Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notes export option #429

Merged
merged 5 commits into from
Feb 23, 2022
Merged

add notes export option #429

merged 5 commits into from
Feb 23, 2022

Conversation

chrisns
Copy link
Contributor

@chrisns chrisns commented Feb 18, 2022

fixes #278

@chrisns
Copy link
Contributor Author

chrisns commented Feb 19, 2022

can't figure out in the coverage, appears to show that i'm changing src/utils/chrome-finder.ts but I'm not?

@yhatt yhatt self-requested a review February 19, 2022 05:16
yhatt
yhatt reviewed Feb 19, 2022
View reviewed changes
Copy link
Member

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's due to prevented CI against Windows in forked branch by default. I just approved to run and it looks good 😄

src/converter.ts Outdated Show resolved Hide resolved
src/converter.ts Outdated Show resolved Hide resolved
src/converter.ts Outdated Show resolved Hide resolved
@yhatt yhatt merged commit b2e2f90 into marp-team:main Feb 23, 2022
@yhatt yhatt mentioned this pull request Feb 23, 2022
Merged
4 tasks
@chrisns chrisns deleted the notes_export branch April 8, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhatt yhatt yhatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate presenter notes
2 participants
@chrisns @yhatt