Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the presenter view to be resized #427

Merged
merged 9 commits into from
Feb 23, 2022
Merged

allow the presenter view to be resized #427

merged 9 commits into from
Feb 23, 2022

Conversation

chrisns
Copy link
Contributor

@chrisns chrisns commented Feb 18, 2022

with lots of notes this the presenter view can be difficult to use
this allows the area to be resized

image

@chrisns
Copy link
Contributor Author

chrisns commented Feb 18, 2022

made it a bit better
Feb-18-2022 17-24-08

please feel free to squash the changes to avoid tracking my noise :)

@yhatt yhatt self-requested a review February 19, 2022 05:16
yhatt
yhatt reviewed Feb 19, 2022
View reviewed changes
Copy link
Member

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

src/templates/bespoke/bespoke.scss Outdated Show resolved Hide resolved
src/templates/bespoke/presenter/presenter-view.tsx Outdated Show resolved Hide resolved
@yhatt yhatt mentioned this pull request Feb 19, 2022
Closed
yhatt
yhatt reviewed Feb 23, 2022
View reviewed changes
src/templates/bespoke/bespoke.scss Show resolved Hide resolved
test/templates/bespoke.ts Outdated Show resolved Hide resolved
test/templates/bespoke.ts Outdated Show resolved Hide resolved
src/templates/bespoke/bespoke.scss Outdated Show resolved Hide resolved
yhatt
yhatt approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for continued contributions with patience! 😄

@yhatt yhatt merged commit eb34446 into marp-team:main Feb 23, 2022
@chrisns
Copy link
Contributor Author

chrisns commented Feb 23, 2022

Approved. Thanks for continued contributions with patience! 😄

it's a pleasure, thanks for the great and super quick feedback 👍

@chrisns chrisns deleted the patch-1 branch February 23, 2022 12:20
@yhatt
Copy link
Member

yhatt commented Feb 23, 2022

I found out a bug locking isDragging state even after released mouse button when the splitter was dropped to the outside of window. I'll follow up in another pull request.

@chrisns
Copy link
Contributor Author

chrisns commented Feb 23, 2022

oh thats a good one, didn't think of that edge case 👍

yhatt added a commit that referenced this pull request Feb 23, 2022
@yhatt
Follow up #427
0f2f4ba 
- Fix locked dragging state when dropped splitter to the out of window
- Improve interaction of the splitter
- Leave full width of splitter if it was in the edge
- Prettify the code
@yhatt yhatt mentioned this pull request Feb 23, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhatt yhatt yhatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisns @yhatt