Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Includes security update] Upgrade dependent packages to latest #40

Merged
merged 3 commits into from
Nov 24, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Nov 24, 2018

Upgrade dependent packages to latest version by using yarn upgrade-interactive --latest. The motivation is as same as marp-team/marpit#96 and marp-team/marp-core#50.

  • It includes an important upgrade of npm-run-all v4.1.5. The malicious code has been reported in v4.1.3's dependency. (marp-cli -> marp-core / marpit -> npm-run-all -> ps-tree -> event-stream -> [email protected] [reported malicious code])

  • By the reason as same as Upgrade dependent packages to latest #36, rollup-plugin-pug is not upgraded to the latest version. Node 6 maintenance LTS will end in April 2019, so we should keep the current verion until then it.

  • marp-core is no longer using markdown-it-katex, so we are no more needed resolutions field to prevent double-bundling.

Currently we are working to the documentation at docs branch. We had planned that a next release will become to be the first minor release included documents and updates of package. However, we have to keep publishing pre-release versions because it is required the security measures like this PR.

It includes an upgrade to prevent the malicious attack included in
dependency of npm-run-all.

See: mysticatea/npm-run-all#149
write "^0.2.1"

flatmap-stream@^0.1.0:
version "0.1.1"
resolved "https://registry.yarnpkg.com/flatmap-stream/-/flatmap-stream-0.1.1.tgz#d34f39ef3b9aa5a2fc225016bd3adf28ac5ae6ea"
Copy link
Member Author

@yhatt yhatt Nov 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've confirmed an important deletion to prevent the malicious attack.

@yhatt yhatt merged commit abcee5c into master Nov 24, 2018
@yhatt yhatt deleted the upgrade-dependencies branch November 24, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant