-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conversion from standard input #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 161bb29.
By using environments, it can change cache key on CircleCI.
yhatt
commented
Aug 25, 2018
} | ||
|
||
export class Converter { | ||
readonly options: ConverterOption | ||
|
||
constructor(opts: ConverterOption) { | ||
this.options = opts | ||
|
||
if (opts.type === ConvertType.pdf && opts.output === '-') | ||
error('PDF cannot output to stdout.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this change, we no longer restrict to output PDF into stdout. The default output path will decide by where came input from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will support the conversion from standard input. It could chain process by pipe.
By using
curl
, it will become that can convert Marp Markdown on network resource easily.The converted buffer came from stdin would output to stdout if you not specified
--output
option. You can continue processing by piping output to another tools.For example, you can extract specified pages from converted PDF by using PDFtk server.