Improve the behavior of preview mode on macOS #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes below updates to improve the behavior of preview mode on macOS:
Update a Dock icon to suit for the appearance style of macOS Big Sur.
An initial window generated by
--appis no longer used as a preview window because of a bit strange activation behavior when opened a single preview window. In macOS, Chromium browser will try to open a new window with UI like tabs and address bars if there were no windows which were opened throughwindow.open(). So I changed that an initial window via--appwill close immediately and Marp CLI will try to open a new initial window viawindow.open.