Create HTML for Puppeteer-based conversion in Docker into /tmp instead of home directory #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying Puppeteer-based conversion in Linux, Marp CLI will create HTML tmpfile into a home directory instead of
/tmp. It is important because Chromium that is installed through snap cannot read a local file from/tmpby a snap container confinement. (#201 (comment))However, I've found this behavior will break a workflow on Docker with
MARP_USERenv. Marp CLI image does not know about a specified user soos.homedir()will return a path that has no permissions for reading files by Chrome.Thus, I changed to create HTML tmpfile into
/tmpwhen used an official Docker image. Fix #360.