Generate output files under configurable ID, e.g. as the current user #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
reviewed
Apr 4, 2021
Dockerfile
Outdated
| @@ -31,6 +32,10 @@ RUN yarn add puppeteer-core@chrome-$(chromium-browser --version | sed -r 's/^Chr | |||
| RUN yarn install && yarn build && rm -rf ./src ./node_modules && yarn install --production && yarn cache clean \ | |||
| && node /home/marp/.cli/marp-cli.js --version | |||
|
|
|||
| USER root | |||
|
|
|||
| ENV MARPID marp:marp | |||
There was a problem hiding this comment.
I felt the env name MARPID is unclear and a bit obscure. How about using MARP_USER instead?
There was a problem hiding this comment.
Definitely better.
yhatt
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the docker image generates output under the ID of the marp user created inside the image at build time. Usually this will be different from the current user, so it fails unless writing to a world writable location. Also, the file generated has a different owner from the current user.
This PR allows the user to specify a different ID to generate the output.
I suggest adding to the instructions on docker hub:
Thanks for an excellent product, it's a lot of fun to use!