Mark bespoke template as not-printable and apply fallback if Puppeteer is required in bespoke template #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original report: marp-team/marp-vscode#175 If tried using not-printable template in Puppeteer-required conversion, Marp CLI automatically fallbacks into bare template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original report: marp-team/marp-vscode#175
Set
printableflag to each templates, and fallback intobaretemplate if tried Puppeteer conversion in not-printable template.We've found sometimes background images using
![bg]()are not rendered in PDF if using bespoke template and Chrome >= 85. I've recognized this problem as a regression by Chromium, and we should take this workaround until Chrome was fixed.We could have taken to always use bare template in Puppeteer required conversion, but we have a mid term plan for the new printable handout template (#261) so
printableflag is smart solution to keep multiple printable templates.(Probably) we can close #293.