Fix regression in --allow-local-files option with Snapd Chromium #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's caused by tmp's breaking change since v0.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes these bugfixes:
tmpdependency (Upgrade dependent packages to the latest version #229 (comment)) so I fixed the logic for making tmpfile in--allow-local-filesoption./usr/bin/chromium-browser.chrome-launcherwill detect this so we can't detect Snapd Chromium from the executable path. We may still able to detectsnapby reading the content of script but it requires extra file-reading. Thus, we will always create Snapd-compatible tmpfile for--allow-local-filesoption if used CLI in Linux. A tmpfile will always be placed to home directory.Fix #201 again.