Upgrade dependent packages to the latest version #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Aug 20, 2020
Comment on lines
-308
to
-310
| const [img] = slide['relsMedia'] | ||
| slide['bkgdImgRid'] = img.rId | ||
| slide['data'] = [] |
There was a problem hiding this comment.
We don't have to hack internal objects for supporting background image per slide in PptxGenJS v3.3.0 🙌
Comment on lines
+294
to
+297
| // TODO: Revert the workaround for regression about custom layout in PptxGenJS v3.3.0 | ||
| // https://github.com/gitbrent/PptxGenJS/issues/826 | ||
| pptx.presLayout['width'] = pptx.presLayout['_sizeW'] | ||
| pptx.presLayout['height'] = pptx.presLayout['_sizeH'] |
There was a problem hiding this comment.
...but still requires another hack to deal with a regression about the custom slide layout in v3.3.0.
gitbrent/PptxGenJS#826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded dependent packages to the latest version via
yarn upgrade --latest.Notable changes
cosmiconfighas a major update to v7. It will recognizemarp.config.cjsas a configuration file newly.pptxgenjsv3.3.0 has an official support of background image. It might mean Marp does no longer require to hack internal object of pptxgenjs while generating PPTX presentation.