Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control aria-hidden attribute properly in bespoke template #238

Merged
merged 3 commits into from
Jun 28, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jun 28, 2020

Screen-reader does not follow the hidden state of some slide pages and on-screen controller in the exported HTML with bespoke template.

To improve a11y, we've updated some bespoke plugins to control aria-hidden attribute in some elements that are actually not hidden. I've confirmed that a11y was improved, by the accessibility inspector in Firefox developer tools.

Fixed #236.

@yhatt yhatt merged commit 366ce44 into master Jun 28, 2020
@yhatt yhatt deleted the bespoke-template-a11y branch June 28, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slides with code block always verbalized by screen-reader
1 participant