Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce direct dependencies #233

Merged
merged 3 commits into from
Jun 13, 2020
Merged

Reduce direct dependencies #233

merged 3 commits into from
Jun 13, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jun 13, 2020

Moved dependented some helper modules into devDependencies. They will bundle into one file through rollup. By this change, direct dependent packages will reduce by 20%.

  • Pros: Makes faster install by less direct dependencies. (e.g. one-shot usage in npx @marp-team/marp-cli)
  • Cons: Bundled modules cannot catch up bumped minor version so may leave security vulnerabilities in deep dependency.

@yhatt
Reduce direct dependencies
46e8080 
Moved dependented some helper modules into `devDependencies`. They will
bundle into one file through rollup.
@yhatt
Merge branch 'master' into reduce-dependencies
9df02b3
@yhatt
[ci skip] Update CHANGELOG.md
a0ef30b
@yhatt yhatt merged commit 1494f46 into master Jun 13, 2020
@yhatt yhatt deleted the reduce-dependencies branch June 13, 2020 07:35
@yhatt yhatt mentioned this pull request Jul 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yhatt