Hide preview option and indicate that does not support Chrome >= 81 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had expected to merge this and bump version according to the time of releasing Chrome 81 (yesterday), but it seems to be delayed. I've still got Chrome 80 after the update in yesterday. |
|
Upcoming releases for Chrome was paused due to adjusted schedules (It was probably affected by COVID-19). Stopping evolution of Web is feeling like a bit of sadness but this fact luckily gets time to deprecate preview option during the stable Chrome is 80. We can reduce warning level from ERROR to WARN, and note about an error in future release of Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome 81 that is going to release in Mar 17th,
--previewoption won't work due to not updated permissions in unmaintained carlo.The logic of experimental
--previewoption does not change from the current, but Marp CLI will indicate with an error message that--previewoption does not support Chrome >= 81. In addition,-p/--previeware no longer shown in--helptoo (but it can show via--help --show-hidden).Related to #211.