Upgrade Node and dependent packages to the latest version #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bumped Marp Core v1.0.0 seems not to work. Same issue has reported to marp-team/marp-react#19 by user. |
yhatt
commented
Jan 17, 2020
| @@ -4,8 +4,12 @@ import resolve from '../src/engine' | |||
| describe('Engine', () => { | |||
| describe('.resolve', () => { | |||
| it('returns ResolvedEngine class with resolved class', async () => { | |||
| expect((await resolve(Marp)).klass).toBe(Marp) | |||
| expect((await resolve('@marp-team/marp-core')).klass.name).toBe('Marp') | |||
There was a problem hiding this comment.
The name of Marp class provided by Marp Core v1.0.1 has applied minification by bumped terser.
Marp CLI will use name defined in package.json but won't use engine name. We updated test case, to confirm matching a resolved class with imported Marp Core.
yhatt
commented
Jan 17, 2020
| @@ -125,7 +125,8 @@ export class ThemeSet { | |||
| const fnForWatch: Set<string> = new Set(found.map(f => path.resolve(f))) | |||
|
|
|||
| for (const f of fn) { | |||
| if (!hasMagic(f)) { | |||
| // globby's hasMagic (backed by fast-glob) always recognizes "\\" (Windows path separator) as the escape character. | |||
| if (!hasMagic(f.split(path.sep).join('/'))) { | |||
There was a problem hiding this comment.
globby v11 provides hasMagic() backed by fast-glob instead of node-glob. fast-glob will recognize \ (Windows path separator) as a magic character for escape, so we have to normalize it for watching theme directory correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will upgrade Node LTS and dependent packages to the latest version via
yarn upgrade --latest.Notable changes
Node
Dependent packages
rollup-plugin-commonjs=>@rollup/plugin-commonjsrollup-plugin-typescript=>@rollup/plugin-typescript