Improve Puppeteer conversion on WSL environment #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitted userDataDir may make Windows Chrome through WSL fail executing.
yhatt
commented
Nov 3, 2019
| // | ||
| // But it causes invalid rendering in Marp's `inlineSVG` mode. So we override | ||
| // `--disable-features` option to prevent disabling BGPT. | ||
| const args = new Set<string>(['--disable-features=TranslateUI']) |
There was a problem hiding this comment.
The default arguments by Puppeteer is defined --disable-features=BlinkGenPropertyTrees, but rendering of Marp's inline SVG mode requires this feature to prevent glitch. Now we've enabled BGPT forcely because PDF conversion on WSL may return empty slides.
| : `data:text/html;base64,${baseFile.buffer!.toString('base64')}` | ||
| const uri = await (async () => { | ||
| if (tmpFile) { | ||
| if (isWSL()) return `file:${await resolveWSLPath(tmpFile.path)}` |
There was a problem hiding this comment.
Puppeteer is using Windows Chrome, so we have to resolve the file path for WSL if using tmpfile while conversion by enabling --allow-local-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently WSL environment became to need
--no-sandboxoption to execute Windows Chrome. (for PDF / PPTX conversion through Puppeteer)I've improved the initialization of Puppeteer, to work some conversions on WSL again.
Resolves #175 and marp-team/marp-vscode#89.