Add bespoke sync plugin #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Sep 10, 2019
| @@ -76,15 +76,17 @@ | |||
| "@types/ws": "^6.0.2", | |||
| "@types/yargs": "^13.0.2", | |||
| "autoprefixer": "^9.6.1", | |||
| "bespoke": "^1.1.0", | |||
| "bespoke": "bespokejs/bespoke", | |||
There was a problem hiding this comment.
We have to use Bespoke.js from GitHub directly because Bespoke.prototype.destroy() is not defined in the latest release on npm.
| browser: !!opts.browser, | ||
| mainFields: ['module', 'jsnext:main', 'main'], | ||
| }), | ||
| replace({ 'process.env.NODE_ENV': JSON.stringify('production') }), |
There was a problem hiding this comment.
The bundled nanoid package cannot work without replacing process.env.NODE_ENV.
See also: ai/nanoid#127 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The created sync plugin for Bespoke.js makes the state of progress synchronize between multiple windows with passed the same sync key.
Below example defines specific sync key by passing
syncquery parameter.In major browsers,
localStorageinfile://protocol had not worked as of starting development Marp CLI. But now it seems to work. Thus, we will sync the state of slide progress (with fragments support) by using localStorage andstorageevent.This is preparation of future working for the presenter view (#142), and we are not be assumed using
syncquery parameter directly.ToDo