Set up CI for Windows with Azure Pipelines #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now we have got CI build for Windows. It still seems to be unstable by puppeteer/puppeteer#1947 but it would be better than shipping release with bugs. |
|
It is better to run CI in each commit than using |
Use fixed directory path to Carlo profile and omit cleanup.
Override close function of Window to ignore raising an error if a target page has already closed.
yhatt
commented
Jul 2, 2019
| try { | ||
| return await close.call(win) | ||
| } catch (e) { | ||
| if (!e.message.includes('Target closed.')) throw e |
There was a problem hiding this comment.
Even if raising error Target closed., the close event has called correctly. We decided to ignore this error.
| this.carloInternal = await carlo.launch({ | ||
| localDataDir, | ||
| localDataDir: path.resolve(os.tmpdir(), './marp-cli-carlo'), |
There was a problem hiding this comment.
Update the temporary directory to use a fixed path to prevent random failing when finalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #119.
CircleCI is still primary CI service for Marp team. Azure Pipelines will be used only for testing in Windows environment.