New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Server class to handle error while converting #115

Merged

yhatt merged 3 commits into master from refactor-server

Jun 28, 2019

Member

yhatt commented Jun 28, 2019

I've refactored Server class by extending (Typed)EventEmitter to improve error handling while converting Markdown.

A constructor option onConverted is replaced to convert event provided by EventEmitter.
When raising an error while converting Markdown...
- Returns 503 error with raised error message.
- Emits error event with error instance. Marp CLI uses this to output error message to console.

yhatt added 3 commits

June 29, 2019 00:52


          Refactor Server to handle error while converting

450312a


          Add unit test of Server class about emitted events

6b1f467


          [ci skip] Update CHANGELOG.md

f997ea5

yhatt merged commit fd945d6 into master

yhatt deleted the refactor-server branch

June 28, 2019 17:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet