Fix httpServer error handling. #103

saiya · 2019-06-18T09:15:23Z

Fixed to handler httpServer start up error.

For example, current marp-cli ignores EADDRINUSE error as below:

# Start some web server in port 8080
% marp --html --server .
[  INFO ] [Server mode] Start server listened at http://localhost:8080/ ...

# No error message.

Changes:

Properly handle 'error' event of node.js httpServer
Fixed "Unhandled promise rejection" problem on server startup error
Handle EADDRINUSE to show user friendly message

saiya · 2019-06-18T09:17:34Z

src/server.ts

+      httpServer.on('error', (err) => {
+        httpServer.close()
+        if (err['code'] === 'EADDRINUSE') {
+          reject(new CLIError(err.message))


Shows error message like this:

% ./marp-cli.js --html --server . [ ERROR ] listen EADDRINUSE: address already in use :::8080

saiya · 2019-06-18T09:18:35Z

src/server.ts

@@ -39,7 +39,20 @@ export class Server {

  async start() {
    this.setup()
-    new Promise<void>(res => this.server!.listen(this.port, res))
+    return new Promise<void>((resolve, reject) => {


Fixed to return Promise instance.

Current code causes "Unhandled promise rejection" because this Promise was not handled.

yhatt · 2019-06-18T10:48:40Z

Thanks for super nice improvement 😍

saiya commented Jun 18, 2019

View reviewed changes

saiya force-pushed the server_error_handling branch 5 times, most recently from b1bbcf5 to 83ba542 Compare June 18, 2019 09:39

Fix httpServer error handling.

fc93c6c

saiya force-pushed the server_error_handling branch from 83ba542 to fc93c6c Compare June 18, 2019 09:42

yhatt merged commit dfbdd11 into marp-team:master Jun 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix httpServer error handling. #103

Fix httpServer error handling. #103

saiya commented Jun 18, 2019 •

edited

Loading

saiya Jun 18, 2019

saiya Jun 18, 2019 •

edited

Loading

yhatt commented Jun 18, 2019

Fix httpServer error handling. #103

Fix httpServer error handling. #103

Conversation

saiya commented Jun 18, 2019 • edited Loading

saiya Jun 18, 2019

Choose a reason for hiding this comment

saiya Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

yhatt commented Jun 18, 2019

saiya commented Jun 18, 2019 •

edited

Loading

saiya Jun 18, 2019 •

edited

Loading