Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hung up in some environments while getting from stdin #93

Closed
yhatt opened this issue May 9, 2019 · 1 comment · Fixed by #94
Closed

Hung up in some environments while getting from stdin #93

yhatt opened this issue May 9, 2019 · 1 comment · Fixed by #94
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Member

yhatt commented May 9, 2019

I've found some cases that Marp CLI hangs up while getting contents from stdin by using get-stdin module.

It may be related to sindresorhus/get-stdin#13.

@yhatt yhatt added the bug Something isn't working label May 9, 2019
@yhatt
Copy link
Member Author

yhatt commented May 9, 2019

Hmm, I have read discussion about this, and it seems that there is no correct way to resolve this. 🤔

Marp CLI should be continue to support stdin as like as the regular UNIX application. I think that all we can do for problemed environments is what let user opt out the support for reading stdin.

yhatt added a commit that referenced this issue May 10, 2019
Workaround for #93: Allow to disable reading from stdin by `--no-stdin`.
@yhatt yhatt mentioned this issue May 10, 2019
1 task
@yhatt yhatt closed this as completed in #94 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant