Skip to content

Conversation

@cloud-fan
Copy link

@cloud-fan cloud-fan commented Aug 3, 2020

I tried to address my own comments and add the key and value label, but had no luck.

This PR just does 2 simplifications:

  1. reuse the quotedIdentifier parser rule instead of stripping backticks by our own
  2. remove the value label as we can't use it anyway.

This change is Reviewable

@cloud-fan
Copy link
Author

cc @maropu

@maropu maropu merged commit 3065ed9 into maropu:SPARK-32257 Aug 3, 2020
@maropu
Copy link
Owner

maropu commented Aug 3, 2020

Thanks! I checked that SparkSqlParserSuite passed and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants