Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Fix stories with ToggleThemeButton should not persist theme in localStorage #9441

Merged
merged 3 commits into from
Nov 14, 2023
Merged

[Storybook] Fix stories with ToggleThemeButton should not persist theme in localStorage #9441

merged 3 commits into from
Nov 14, 2023

Conversation

erwanMarmelab
Copy link
Contributor

@erwanMarmelab erwanMarmelab commented Nov 12, 2023 •
edited
Loading

Problem

OSS RA storybook had some issues. If you put a story on dark-mode, it could break some other visuals

Solution

Set darkTheme for problematics stories
Add memoryStore to sorties who can toggle theme

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Nov 12, 2023
@slax57 slax57 added this to the 4.15.5 milestone Nov 14, 2023
@slax57 slax57 merged commit 6595ac4 into master Nov 14, 2023
@slax57 slax57 deleted the adapt-stories-theme branch November 14, 2023 09:02
@slax57 slax57 changed the title adapt stories theme [Storybook] Fix stories with ToggleThemeButton should not persist theme in localStorage Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@erwanMarmelab @slax57