Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] introduce classname and sx prop for SolarMenu component #9440

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[Doc] introduce classname and sx prop for SolarMenu component #9440

merged 2 commits into from
Nov 13, 2023

Conversation

adguernier
Copy link
Contributor

Problem

The <SolarMenu>'s sx and className props are missing in the documentation

Solution

Document these props

Plus: add screenshots to demonstrate custom appBar and sx

@adguernier adguernier added the RFR Ready For Review label Nov 10, 2023
@fzaninotto fzaninotto merged commit b2157ce into master Nov 13, 2023
@fzaninotto fzaninotto deleted the docs-add-sx-and-classname-prop-to-solar-menu-and-screenshots branch November 13, 2023 09:19
@fzaninotto fzaninotto added this to the 4.15.5 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 Awaiting requested review from slax57

@erwanMarmelab erwanMarmelab Awaiting requested review from erwanMarmelab

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@adguernier @fzaninotto