Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add gotcha about <Input disabled> usage and isDirty form state #9386

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 24, 2023

Since react-hook-form v7.46.0 and react-hook-form/react-hook-form#10805, a disabled input makes the form dirty. This isn't going to change, so we may as well warn our users about it.

Closes #9378

Since `react-hook-form` v7.46.0, a `disabled` input makes the form dirty. This isn't going to change, so we may as well warn our users about it.
@slax57 slax57 requested a review from adguernier October 24, 2023 16:24
@adguernier adguernier added this to the 4.15.2 milestone Oct 25, 2023
@adguernier adguernier merged commit 255da10 into master Oct 25, 2023
@adguernier adguernier deleted the doc-disabled-input-gotcha branch October 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnWhenUnsavedChanges does not function properly with disabled TextInput
3 participants