Fix closing browser tab loses undoable mutations without warning #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jul 4, 2023
fzaninotto
requested changes
Jul 5, 2023
fzaninotto
approved these changes
Jul 5, 2023
|
Works like a charm! |
fzaninotto
deleted the
8505-undoable-mutations-not-executed-if-user-closes-browser-tab-too-soon
branch
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closing browser tab loses undoable mutations (update or deletion) without warning
Solution
When the user closes the tab, if there is an undoable mutation ongoing, show a dialog to ask the user for confirmation before actually closing the tab. If they cancel, the page should remain open and the mutation proceed.
Fix #8505
Capture.video.2023-07-04.14.44.32.webm