Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix <ReferenceManyField> chapter snippets to match the example data #9067

Merged
merged 7 commits into from
Jul 5, 2023
Merged

[Doc] Fix <ReferenceManyField> chapter snippets to match the example data #9067

merged 7 commits into from
Jul 5, 2023

Conversation

eboss-dev
Copy link
Contributor

field year doesn't exists in the relational model shown in the example, changed all the year to published_at

@eboss-dev
Update ReferenceManyField.md
44efcdd 
field year doesn't exists in the relational model shown in the example, changed all the year to published_at
@fzaninotto
Copy link
Member

Thanks. Could you make it a DateField instead of a TextField?

eboss-dev
eboss-dev commented Jul 3, 2023
View reviewed changes
Copy link
Contributor Author

@eboss-dev eboss-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified DateField for field published at

eboss-dev
eboss-dev commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@eboss-dev eboss-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the DateField in the import

slax57
slax57 requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that the changes look good, thanks

@eboss-dev
Copy link
Contributor Author

Should be good now

@fzaninotto fzaninotto merged commit 9b8f10a into marmelab:master Jul 5, 2023
@fzaninotto
Copy link
Member

all good, thanks!

@fzaninotto fzaninotto added this to the 4.12.1 milestone Jul 5, 2023
@fzaninotto fzaninotto changed the title Update ReferenceManyField.md [doc] Fix <ReferenceManyField> chapter snippets to match the example data Jul 5, 2023
@fzaninotto fzaninotto changed the title [doc] Fix <ReferenceManyField> chapter snippets to match the example data [Doc] Fix <ReferenceManyField> chapter snippets to match the example data Jul 5, 2023
@eboss-dev eboss-dev deleted the patch-1 branch July 5, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eboss-dev @fzaninotto @slax57