Fix Form should only trigger field validation on submit if not told otherwise #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Apr 12, 2023
| @@ -891,6 +891,13 @@ const PersonEdit = () => ( | |||
| ); | |||
| ``` | |||
|
|
|||
| **Reminder:** [react-hook-form's `formState` is wrapped with a Proxy](https://react-hook-form.com/api/useformstate/#rules) to improve render performance and skip extra computation if specific state is not subscribed. So, make sure you deconstruct or read the `formState` before render in order to enable the subscription. | |||
There was a problem hiding this comment.
This one is weird as we don't use useFormState anywhere before or did I miss something?
There was a problem hiding this comment.
We use the formState (formState: { isSubmitted }) so I figured I'd rather add the Reminder here anyway. But I'm open to discussion 😁
| @@ -100,6 +100,13 @@ const LatLngInput = props => { | |||
| }; | |||
| ``` | |||
|
|
|||
| **Reminder:** [react-hook-form's `formState` is wrapped with a Proxy](https://react-hook-form.com/api/useformstate/#rules) to improve render performance and skip extra computation if specific state is not subscribed. So, make sure you deconstruct or read the `formState` before render in order to enable the subscription. | |||
| @@ -146,3 +153,10 @@ const PersonEdit = () => ( | |||
| </Edit> | |||
| ); | |||
| ``` | |||
|
|
|||
djhi
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8799
Todo