localStorageStore now delete only items prefixed on version change #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
approved these changes
Oct 27, 2022
slax57
requested changes
Oct 27, 2022
| getStorage().clear(); | ||
| const storage = getStorage(); | ||
| Object.keys(storage).forEach(key => { | ||
| if (key.startsWith(`${prefix}`)) { |
There was a problem hiding this comment.
suggestion:
Suggested change
| if (key.startsWith(`${prefix}`)) { | |
| if (key.startsWith(prefix)) { |
Comment on lines
+43
to
+52
| describe('reset preserving items outside Ra-Store', () => { | ||
| it('should reset the store', () => { | ||
| const store = localStorageStore(); | ||
| store.setItem('foo', 'bar'); | ||
| getStorage().setItem('baz', 'baz'); //set custom item in localstorage | ||
| store.reset(); | ||
| expect(getStorage().getItem('baz')).toEqual('baz'); //expect not to be wiped on store reset | ||
| expect(store.getItem('foo')).toEqual(undefined); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This test is good (and should be kept), but you are actually not testing the code you added. You should add a test about version change.
fzan
commented
Oct 27, 2022
fzaninotto
approved these changes
Oct 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue on #8312