Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayInput helperText not showing error message #8154

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix ArrayInput helperText not showing error message #8154

merged 1 commit into from
Sep 9, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Sep 8, 2022 •
edited by slax57
Loading

Fixes #8153

@WiXSL WiXSL added the RFR Ready For Review label Sep 8, 2022
@WiXSL WiXSL added this to the 4.3.2 milestone Sep 8, 2022
slax57
slax57 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great find!! 😃
I believe this aims at fixing #8153 ? (if so, we should mention it in the PR description)

One last thing still puzzles me: how could this work in RA v4.2.6? 🤔

@slax57
Copy link
Contributor

slax57 commented Sep 9, 2022

Okay I get it now, this regression was caused by https://github.com/marmelab/react-admin/pull/8080/files#diff-d599f69bbbccae699c58ac0c3ab76dde15cb75ae9280b8ecc4d206f650a0fc99R175

So basically your PR is the right way to fix it IMO. Again, well done 🙂

@slax57 slax57 merged commit bef5cc4 into master Sep 9, 2022
@slax57 slax57 deleted the fix-arrayinput-hrlpertext branch September 9, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.

ArrayInput does not show validation errors if using schema validation (with yup)
2 participants
@WiXSL @slax57